WRR-11077: Fixed Scroller to prevent the native scrolling behavior caused by keydown events when the popup is opened #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixedPopupPanels Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1756 +/- ##
===========================================
+ Coverage 80.89% 80.96% +0.07%
===========================================
Files 148 148
Lines 6672 6709 +37
Branches 1988 2005 +17
===========================================
+ Hits 5397 5432 +35
- Misses 967 969 +2
Partials 308 308 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
MikyungKim
changed the title
|
Please resolve the merge conflict. |
MikyungKim
reviewed
Dec 3, 2024
.travis.yml
Outdated
| @@ -16,7 +16,7 @@ install: | |||
| - npm install | |||
| - npm link | |||
| - popd | |||
| - git clone --branch=develop --depth 1 https://github.com/enactjs/enact ../enact | |||
| - git clone --branch=feature/WRR-11077 --depth 1 https://github.com/enactjs/enact ../enact | |||
There was a problem hiding this comment.
Don't forget to revert the change before merging.
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Checklist
Issue Resolved / Feature Added
When the Scroller has a button that opens FixedPopupPanel. The issue is that when press the down key at the moment the popup is opened the scroller behind the FixedPopupPanel scrolls down.
Resolution
To fix this issue, we have to prevent the native scrolling behavior caused by keydown events.
I created preventScroll function which call
preventDefaultwhen a keydown event is caused by a directional key and the spotlight is paused.I added this preventScroll function to useThemeScroll so that it can be passed to ui/Scroller and used as prop.
Also I added the issue case in Scroller qa-sampler
Additional Considerations
Links
WRR-11077
Comments